Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on JRuby 9.2.0.0 - "sends a UTF-8 body" #75

Closed
olleolleolle opened this issue May 24, 2018 · 3 comments
Closed

Test fails on JRuby 9.2.0.0 - "sends a UTF-8 body" #75

olleolleolle opened this issue May 24, 2018 · 3 comments

Comments

@olleolleolle
Copy link
Collaborator

olleolleolle commented May 24, 2018

This test fails on JRuby 9.2.0.0.

    it "sends a UTF-8 body" do
      response = client.post(local_server, body: "This is a post body ∑")
      expect(JSON.load(response.body)["body"]).to eq "This is a post body ∑"
    end

Source location

Example failure:

  1) Manticore::Client#post sends a UTF-8 body
     Failure/Error: expect(JSON.load(response.body)["body"]).to eq "This is a post body ∑"
     
       expected: "This is a post body ∑"
            got: "This is a post body â\u0088\u0091"
     
       (compared using ==)
     # ./spec/manticore/client_spec.rb:461:in `block in (root)'

Test passes on 9.0.5.0 - https://travis-ci.org/cheald/manticore/jobs/383309866

Build 221 overview - https://travis-ci.org/cheald/manticore/builds/383309863

@olleolleolle
Copy link
Collaborator Author

OH: "Smells JI"

@cheald
Copy link
Owner

cheald commented May 28, 2018

The fix for #70 and treating our test JSON payloads as application/json should fix this.

@cheald cheald closed this as completed in 4ee6315 May 28, 2018
@olleolleolle
Copy link
Collaborator Author

@cheald Huzzah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants