Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review - Choose to bind methods with this or with arrow functions #36

Closed
jaepass opened this issue May 8, 2020 · 2 comments
Closed

Review - Choose to bind methods with this or with arrow functions #36

jaepass opened this issue May 8, 2020 · 2 comments

Comments

@jaepass
Copy link
Contributor

jaepass commented May 8, 2020

Choose to bind methods with this or with arrow functions and keep it consistent across the whole codebase
@robbieaverill
Copy link
Contributor

We've agreed to use binding

@linear linear bot mentioned this issue May 8, 2020
Merged
@robbieaverill
Copy link
Contributor

Done in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robbieaverill @jaepass