-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control severity of sarif reports #43
Comments
The default is: Lines 210 to 213 in d7cd297
If you wanted to include with:
warnings: unrecognized-spelling,bad-regex,binary-file,deprecated-feature,large-file,limited-references,no-newline-at-eof,noisy-file,non-alpha-in-dictionary,unexpected-line-ending,whitespace-in-dictionary,minified-file,unsupported-configuration |
I've made the following changes:
|
Please let me know if this covers what you're looking for / if you have any problems. |
Thank you for your reply! Now I can treat unrecognized spellings as warning in action log. But is there a way to treat it as warning in Security tab of my repo? |
Oh, interesting, you're using Sarif? Not currently, how much control do you want/need? I could allow you to specify a replacement Sarif template... Or I could provide a thing similar to the warnings flag, or I could try to apply the values from One concern I have w/ letting you replace the file entirely is that when you upgrade, you'd lose whatever new items it defines. (I'd love to get feedback on your experience of using Sarif, it's a new feature and I don't think many people have deployed it yet.) |
I've also added warnings to https://github.com/check-spelling/check-spelling/wiki/Configuration#warnings. I'll need to spend some time reviewing the full list to see if I've missed anything else... |
Thinking about the Sarif side a bit, I think what I'll do is let you write a That's pretty workable, since check-spelling/generate-sarif.pl Line 38 in 07584a3
I suspect I'll look into this the next time I look at the Sarif handling (probably in a week or two). |
I've temporaily disabled sarif since it's spamming the repo's security tab. Please inform me when it's polished better.
My request is to treat events defined as warning in the yml file as warning in sarif too. Or the security tab is full of error alerts. Thank you for creating this amazing repo! |
I've implemented a version of this in: d5a7faa. Just drop in a file, something like https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/t/sarif.json into I'd love to get some feedback before this ships. |
In wiki I see that user can configure specific events like
unrecognized-spelling
as warning, but I can't find any example or hint to apply it.The text was updated successfully, but these errors were encountered: