Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed for MacOS #433

Open
secure-sw-dev-bot opened this issue Jan 15, 2022 · 2 comments
Open

Fixed for MacOS #433

secure-sw-dev-bot opened this issue Jan 15, 2022 · 2 comments

Comments

@secure-sw-dev-bot
Copy link

This issue was copied from microsoft/checkedc#434

Mac OS sets macros for string functions and has _FORTIFY_SOURCE set to 2.
@secure-sw-dev-bot
Copy link
Author

Comment from @sulekhark:

Hi @aaronjeline, thank you for your work on this and for submitting this PR. It will be great if the following review comments are addressed:

  1. The comments on lines 54 thro' 61 need to be updated stating why the definitions are necessary in the macOS environment in spite of FORTIFY_SOURCE being greater than 0.
  2. The fix should be applicable only in the macOS environment when FORTIFY_SOURCE == 2. It should not change definitions in non-macOS environments when FORTIFY_SOURCE ==2.
  3. The same fix is also applicable to some definitions in stdio_checked.h.

@secure-sw-dev-bot
Copy link
Author

Comment from @dtarditi:

@aaronjeline, thanks for the changes! Could you address the pull request feedback so that we can commit this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@secure-sw-dev-bot