You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scan queuing is not possible anymore starting from CxFlow 1.6.29 onwards, the condition for having the property checked was removed.
Expected Behavior
When setting checkmarx.scan-queing to true, scans are note being queued in CxSAST and should take priority over cx-flow.scan-resubmit, meaning that scan-resubmit should be ignored if scan-queuing is set.
Actual Behavior
Queuing is not working with checkmarx.scan-queuing: true, that condition is only used later on the code's logic and only when cx-flow.scan-resubmit: true and that's wrong. These settings should be mutually exclusive with queuing having priority/precedence over scan resubmission, meaning if checkmarx.scan-queuing is true then the cx-flow.scan-resubmit feature code shouldn't even be used.
With both checkmarx.scan-queuing and cx-flow.scan-resubmit set to true the problem is that resubmission is not ignored and the current scan will be canceled first instead of being queued and a new one will start immediately, that is wrong as the current scan shouldn't be cancelled with checkmarx.scan-queuing set to true.
This regression was introduced in #884 when the if condition if(!getCxPropertiesBase().getScanQueuing()) (...) that checked for the checkmarx.scan-queuing active condition was removed.
I also found that queuing is internal to the checkmarx-spring-boot-sdk, and because of this, there should be:
Informative logging each 5 minutes or so telling the scan of the current project hasn't finished yet and;
Setting checkmarx.scan-queuing to true and resubmitting multiple scans to the same project shouldn't work.
If there's a scan in queue and checkmarx.scan-resubmit is true, the current scan should be cancelled and a new one starts, if it's false then Cxflow will cancel (as expected) the scan re-submission and never put it in queue.
Environment Details
CxFlow 1.6.29, 1.6.30+
The text was updated successfully, but these errors were encountered:
Description
Scan queuing is not possible anymore starting from CxFlow 1.6.29 onwards, the condition for having the property checked was removed.
Expected Behavior
When setting
checkmarx.scan-queing
to true, scans are note being queued in CxSAST and should take priority overcx-flow.scan-resubmit
, meaning that scan-resubmit should be ignored if scan-queuing is set.Actual Behavior
Queuing is not working with
checkmarx.scan-queuing: true
, that condition is only used later on the code's logic and only whencx-flow.scan-resubmit: true
and that's wrong. These settings should be mutually exclusive with queuing having priority/precedence over scan resubmission, meaning ifcheckmarx.scan-queuing
istrue
then thecx-flow.scan-resubmit
feature code shouldn't even be used.With both
checkmarx.scan-queuing
andcx-flow.scan-resubmit
set to true the problem is that resubmission is not ignored and the current scan will be canceled first instead of being queued and a new one will start immediately, that is wrong as the current scan shouldn't be cancelled withcheckmarx.scan-queuing
set totrue
.This regression was introduced in #884 when the if condition
if(!getCxPropertiesBase().getScanQueuing()) (...)
that checked for thecheckmarx.scan-queuing
active condition was removed.I also found that queuing is internal to the checkmarx-spring-boot-sdk, and because of this, there should be:
Reproduction
Setting
checkmarx.scan-queuing
to true and resubmitting multiple scans to the same project shouldn't work.If there's a scan in queue and
checkmarx.scan-resubmit
istrue
, the current scan should be cancelled and a new one starts, if it's false then Cxflow will cancel (as expected) the scan re-submission and never put it in queue.Environment Details
CxFlow 1.6.29, 1.6.30+
The text was updated successfully, but these errors were encountered: