Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially wrong queries #6233

Closed
giladshahar opened this issue Mar 14, 2023 · 3 comments · Fixed by #6974
Closed

Potentially wrong queries #6233

giladshahar opened this issue Mar 14, 2023 · 3 comments · Fixed by #6974
Labels
appsec bug Something isn't working community Community contribution

Comments

@giladshahar
Copy link

there are existing queries that point out non-issues.
specifically, having requests.memory/cpu != limits.memory/cpu is not an issue (but a best practice).
resource limits are supposed to help users avoid OOM/throttling, while resource requests make sure resources are actually allocated for the containers.

even in the [https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/](link attached) as help for these queries, the example shows limits>requests.

Expected Behavior

containers having requests.memory/cpu != limits.memory/cpu will not trigger an issue.

queries:

aafa7d94-62de-4fbf-8838-b69ee217b0e6
9d43040e-e703-4e16-8bfe-8d4da10fa7e6
aee3c7d2-a811-4201-90c7-11c028be9a46

should be removed

Actual Behavior

containers having requests.memory/cpu != limits.memory/cpu trigger an issue.

@giladshahar giladshahar added bug Something isn't working community Community contribution labels Mar 14, 2023
@kaplanlior
Copy link
Member

Do you suggest to to remove these queries or change their severity (e.g. informational) ?

@giladshahar
Copy link
Author

well I'd remove them

@gabriel-cx
Copy link
Collaborator

Hi @giladshahar ,

Thank you for your inputs on this.
We asked our AppSec team to have a look on this. We will update you asap.

(APPSEC-2347)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec bug Something isn't working community Community contribution
Projects
None yet
3 participants