Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/autofill #188

Closed
wants to merge 3 commits into from
Closed

Feature/autofill #188

wants to merge 3 commits into from

Conversation

benju69
Copy link
Contributor

@benju69 benju69 commented Jan 2, 2023 •
edited

Issue

Resolves #47

Proposed changes

Add Autofill for credit card number, date and cvv fields in compose

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

Further comments

About the Autofill api
https://bryanherbst.com/2021/04/13/compose-autofill/
https://developer.android.com/reference/kotlin/androidx/compose/ui/autofill/AutofillNode

@benju69 benju69 requested a review from a team as a code owner January 2, 2023 13:39
@benju69
Copy link
Contributor Author

benju69 commented Jan 5, 2023

Can you check this? @maxim-nosov-cko

@patrick-hoban-cko
Copy link
Contributor

Hey @benju69, awesome that you're raising PRs to our repo, we love to see it 💯

Unfortunately we can't add this sort of functionality to the SDK due to compliance reasons. We have taken steps to ensure our SDKs allow merchants to adhere to low levels of PCI compliance, which means they should not directly touch or alter card details - hence we can't add an autofill feature at this time without a more thorough review.

If you have any questions around compliance and the implications of this sort of functionality, please feel to message me directly, or drop me an email.

@benju69
Copy link
Contributor Author

benju69 commented Jan 19, 2023

Hey @benju69, awesome that you're raising PRs to our repo, we love to see it 💯

Unfortunately we can't add this sort of functionality to the SDK due to compliance reasons. We have taken steps to ensure our SDKs allow merchants to adhere to low levels of PCI compliance, which means they should not directly touch or alter card details - hence we can't add an autofill feature at this time without a more thorough review.

If you have any questions around compliance and the implications of this sort of functionality, please feel to message me directly, or drop me an email.

Hey @patrick-hoban-cko yes tell me more about compliance please. I don't understand this is a Android feature for users to add more easily the card info, nothing related with merchants, we had this feature before in the version before 4.0

@patrick-hoban-cko
Copy link
Contributor

Hey @benju69 feel free to drop me an email at patrick.hoban@checkout.com and I'd be happy to discuss more.

@benju69
Copy link
Contributor Author

benju69 commented Feb 6, 2023

I dropped you an email @patrick-hoban-cko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Payments don't auto fill the expiration date
2 participants
@benju69 @patrick-hoban-cko