Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12 #22

Closed
fahedalahmad opened this issue Sep 20, 2020 · 8 comments
Closed

Xcode 12 #22

fahedalahmad opened this issue Sep 20, 2020 · 8 comments

Comments

@fahedalahmad
Copy link

Xcode 12: 'PhoneNumberKit' has different definitions in different modules; first difference is definition in module 'PhoneNumberKit.Swift' found method with no designater initializer

i am using PhoneNumberKit
[https://github.com/marmelroy/PhoneNumberKit]

@christiygag
Copy link

Same issue here. I have integrated PhoneNumberKit and frames-ios through pods. But the definitions are conflicting in Xcode 12.

Any workarounds?

@fahedalahmad
Copy link
Author

fahedalahmad commented Sep 21, 2020

@christiygag I have manually named PhoneNumberKit to PhoneNumberKitFrames in Frames framework and it worked for me. until one of them decide to change the class name.

@daven-gomes-cko
Copy link
Contributor

Hi @fahedalahmad, @christiygag,

Frames-ios contains PhoneNumberKit in its repository (as copied source files, not integrated with any dependency managers). If you were to remove PhoneNumberKit from your Pods (or your other integration method), would your apps compile? My theory is your apps would then refer to the PhoneNumberKit classes/methods in Frames-ios.

This could be a temporary solution for now while we investigate this issue.

@erenbesel
Copy link

Any update on this @daven-gomes-cko ?
Removing PhoneNumberkit pod is no help as it has its own updates for Xcode 12. I am looking into downloading Frames-ios manually until you guys provide a fix. How can we setup frames manually? Installation steps only show Cocoapods and Carthage.

@daven-gomes-cko
Copy link
Contributor

Hi @erenbesel, we are planning to release a new version of Frames that will rename our use of PhoneNumberKit next week. For now, can you point your dependency manager to the branch make-phone-number-kit-internal-rename please? This renames our uses of PhoneNumberKit so you can continue to use PhoneNumberKit directly with your own integration. Thanks.

@erenbesel
Copy link

Hi @daven-gomes-cko, thank you. If you are releasing an update next week, may I ask will you also update your own phonenumberkit or only rename it? Maybe we can only use yours if it will be up to date. Thanks.

@daven-gomes-cko
Copy link
Contributor

Hi @erenbesel, sure we can update our version of PhoneNumberKit and rename it. When we release it I'll post in this thread to let you know it's available.

@daven-gomes-cko
Copy link
Contributor

Hi all, a new version of Frames is available (3.1.0). This updates PhoneNumberKit and renames it to CKOPhoneNumberKit. Please let us know if you have any other issues. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants