Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing addressLines missing in CkoCardTokenResponse #72

Closed
sebskuse opened this issue Jun 3, 2021 · 2 comments · Fixed by #73
Closed

Billing addressLines missing in CkoCardTokenResponse #72

sebskuse opened this issue Jun 3, 2021 · 2 comments · Fixed by #73

Comments

@sebskuse
Copy link

sebskuse commented Jun 3, 2021

Describe the bug
I've just gotten round to upgrading us from 3.3.0 to 3.4.2, and just caught a potential problem in that the token response no longer seems to contain the billing addressLines.

We're definitely setting these on the checkout controller in the same way as on 3.3.0 (the only source changes are FramesIos -> Frames in the codebase), and switching back to 3.3.0 works as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Set a billing address with addressViewController.setFields(address:phone) (verify addressLine1 / 2 are set)
  2. Go through checkout journey
  3. Receive callback to func onTapDone(controller: CardViewController, cardToken: CkoCardTokenResponse?, status: CheckoutTokenStatus)
  4. Inspect cardToken and see addressLines are nil.

Expected behavior
Address lines should be present

@deepesh-vasthimal-cko
Copy link
Contributor

@sebskuse. Thank you for raising this issue. I am able to reproduce this and will soon plan for a fix.

@deepesh-vasthimal-cko
Copy link
Contributor

@sebskuse This is now fixed in latest release. Please refer : https://github.com/checkout/frames-ios/releases/tag/3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants