Can't join the target namespace if the PID number is bigger than 65535

[zhouxinyu]

Hi,

I found criu will treat the PID number as a file path when using join-ns feature if the number is bigger than 65535:

criu/criu/namespaces.c

Line 78 in aeeec21

|| (val < 0) || (val > 65535)) {

if ((errno == ERANGE) || (endptr == str)
			|| (*endptr != '\0')
			|| (val < 0) || (val > 65535)) {
		str = NULL;
		return -1;
	}

Is it necessary to have this limitation?

[avagin]

Cc: @xemul

[xemul]

Sorry for just noticing this :)

This is not a "limitation", this is an attempt to distinguish /proc/ path from anything else (e.g. ip tool's bindmounts). And looking at the code I'd say it's quite buggy :(

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[github-actions]

A friendly reminder that this issue had no activity for 30 days.

[github-actions]

A friendly reminder that this issue had no activity for 30 days.