Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the evalResult for kafka, kinesis and pubsub logging #203

Closed
zhouzhuojie opened this issue Jan 10, 2019 · 1 comment
Closed

Comments

@zhouzhuojie
Copy link
Collaborator

zhouzhuojie commented Jan 10, 2019

It would be great to merge the evalResult struct for kafka and kinesis. It make future vendors for data recording easier.

https://github.com/checkr/flagr/blob/master/pkg/handler/data_recorder_kafka.go#L136
https://github.com/checkr/flagr/blob/master/pkg/handler/data_recorder_kinesis.go#L88

type kafkaMessageFrame struct {
	Payload   string `json:"payload"`
	Encrypted bool   `json:"encrypted"`
}
type kinesisMessageFrame struct {
	Payload   string `json:"payload"`
	Encrypted bool   `json:"encrypted"`
}
@zhouzhuojie
Copy link
Collaborator Author

Note, we also need to consolidate pubsub as well

@zhouzhuojie zhouzhuojie changed the title Consolidate the evalResult for kafka and kinesis logging Consolidate the evalResult for kafka, kinesis and pubsub logging Feb 27, 2019
This was referenced Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant