Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dd metrics #179

Merged
merged 1 commit into from Oct 10, 2018
Merged

Remove some dd metrics #179

merged 1 commit into from Oct 10, 2018

Conversation

zhouzhuojie
Copy link
Collaborator

FlagSnapshotID and SegmentID can be pushed for offline analytics. Not super useful in real-time monitoring for now.

@codecov-io
Copy link

Codecov Report

Merging #179 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage    90.7%   90.83%   +0.12%     
==========================================
  Files          25       25              
  Lines        1410     1408       -2     
==========================================
  Hits         1279     1279              
+ Misses         98       96       -2     
  Partials       33       33
Impacted Files Coverage Δ
pkg/handler/eval.go 84.37% <ø> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b41d74...a1c9acd. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit 5d33474 into master Oct 10, 2018
@zhouzhuojie zhouzhuojie deleted the zz/remove-some-metrics branch October 10, 2018 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants