Pull #12154: Use OS specific command and correct errorExtractingPattern

[Vyom-Yadav]

This PR contains:

1. Usage of OS specific command: (Exception without this modification in Windows OS) (Bug Fix)

Caught: java.io.IOException: Cannot run program "mvn": CreateProcess error=2, The system cannot find the file specified
java.io.IOException: Cannot run program "mvn": CreateProcess error=2, The system cannot find the file specified
        at error-prone-check.getErrorProneErrors(error-prone-check.groovy:87)
        at error-prone-check.checkErrorProneReport(error-prone-check.groovy:63)
        at error-prone-check.parseArgumentAndExecute(error-prone-check.groovy:41)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at error-prone-check.run(error-prone-check.groovy:19)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified
        ... 10 more

2. Changed directory separator from / to [\\\\/] (Bug Fix)

3. Removed redundant escapes (\\]) (Enhancement)

[Vyom-Yadav]

Works fine, tested locally on windows.

[romani]

please change commit to Pull #12154: ..... and explain kin PR description reason on why this update is required.
I am curious why were ok without in past and who will benefit from this update, and what problem had such people wihtout this update.

[nrmancuso]

I am good as long as CI is passing and we have confirmation from @rnveach that this script works. I do not have access to a windows machine, and I do not think it is worth it to add to Windows CI just to prove it.

[rnveach]

Summary: TotalFiles=3 FilesWithViolations=1 P1=0 P2=0 P3=1

File: error-prone-check.groovy
    Violation: Rule=UnnecessarySemicolon P=3 Line=124 Msg=[Semi-colons as line endings can be removed safely] Src=[            .compile(".*[\\\\/](.*\\.java):\\[(\\d+).*\\[(\\w+)](.*)");]

[CodeNarc (http://www.codenarc.org/) v1.4]
CodeNarc completed: (p1=0; p2=0; p3=1) 5768ms

[rnveach]

CI failure.

[Vyom-Yadav]

CI failure.

Fixed

[romani]

Usage of OS specific command:

Please share a command and what OS you use.
I still do not understand what problem we have.we never had such problem. In what condition it happens?

[Vyom-Yadav]

Usage of OS specific command:

Please share a command and what OS you use. I still do not understand what problem we have.we never had such problem. In what condition it happens?

Only this script uses maven. We never had this problem because the contribution repo is handling it properly. See https://github.com/checkstyle/contribution/blob/1b3e33600898a849791dc88c90df2bb3f80400e7/checkstyle-tester/diff.groovy#L669-L689

You can normally execute mvn clean verify in windows, but when you use it like command.execute() then it throws and exception.

[Vyom-Yadav]

See https://stackoverflow.com/q/9674220/14425335

[romani]

Ok it is win os, for new script that we created recently.