Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull #13285: Ensure category index page tables are in sync with checks.xml page table #13285

Merged
merged 1 commit into from Jun 22, 2023

Conversation

stoyanK7
Copy link
Collaborator

@stoyanK7 stoyanK7 commented Jun 21, 2023

Identified at #13258 (comment)

The tables in index.xml in each category(blocks, naming,etc..) are an exact copy of checks.xml. It turned out that the script doesn't extract them correctly, hence we need this check.

Test run found 3 issues merged. Here is one

The summary for check WhitespaceAfter in the file "src/xdocs/checks/whitespace/index.xml" should match the summary for this check in the file "src/xdocs/checks.xml"
expected: Checks that a token is followed by whitespace, with the exception that it does not check for whitespace after the semicolon of an empty for iterator.
but was : Checks that there is at least one whitespace after the leading asterisk.

Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@romani romani merged commit 8545cb5 into checkstyle:master Jun 22, 2023
110 checks passed
@github-actions github-actions bot added this to the 10.12.1 milestone Jun 22, 2023
@stoyanK7 stoyanK7 deleted the minor/table-test branch June 22, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants