Pull #14518: move AllBlockCommentTest and AllSinglelineCommentsTest to AST Tests

[mahfouz72]

issue #14249:

• updated inner test check to do violation on block comments rather than only static update
• used input file with inline config to test the check

[mahfouz72]

I think CI failure is unrelated

[nrmancuso]

Items:

[nrmancuso]

Please investigate a bit and leave a comment above this test method (or class) that describes why we need such a strange test. If it is not obvious, let's remove it completely and see what fails.

[mahfouz72]

@nrmancuso Honestly idk I found it weird too. just updated it to be an example for the issue. but I will investigate

[nrmancuso]

#14537

[nrmancuso]

@mahfouz72 if CI is green in #14537, please just do as I have there and delete this class completely. Make sure to grep for this class name to remove any mentions of it as well.

Edit: CI is green, let's proceed with removal.

[mahfouz72]

@nrmancuso should I close this PR? or just update it after the removal

[romani]

Input file that is full of block multi line comments https://github.com/checkstyle/checkstyle/blob/master/src/test/resources/com/puppycrawl/tools/checkstyle/grammar/comments/InputFullOfBlockComments.java

We just need to change

/*0*//*1*/package/*2*/ com/*3*/./*4*/puppycrawl/*5*/./*6*/tools/*7*/./*8*/checkstyle.grammar/*9*/./*10*/comments/*11*/;/*12*/
/*13*/

To more verbose:

/*0*//*1*/package/*2*/ com/*3*/./*4*/puppycrawl/*5*/./*6*/tools/*7*/./*8*/checkstyle.grammar/*9*/./*10*/comments/*11*/;/*12*/
// 12 violations above:
//.           '0'
//.           '1'

[nrmancuso]

This test just test our ability to detect comments at any possible place. It might not be required for coverage but it helps to control parsing

Ok, then let’s create a test for the AST with comments generated by this file.

[romani]

yes, good idea, this is exactly what we wanted many years ago, but we did not have this concept at all.

[romani]

@mahfouz72 , please move this test to AST tests
Example:

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/grammar/AstRegressionTest.java

Lines 73 to 76 in 8531fec

	public void testAdvanceJava9TryWithResourcesAstTree() throws Exception {
	verifyAst(getPath("ExpectedAdvanceJava9TryWithResources.txt"),
	getPath("/java9/InputAdvanceJava9TryWithResources.java"));
	}

[mahfouz72]

@romani done I have moved singlelineCommentTest also to AST test. CI will be green after merging #14567

[nrmancuso]

Glad to clean things up, @mahfouz72 thanks a lot for this!

[romani]

Please see comment above

[mahfouz72]

Please see comment above

@romani please review

[nrmancuso]

A lot of back and forth on this one, @mahfouz72 thanks for hanging in there!

[romani]

I like this update, it becomes much better