Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #13675: add constructor call token to MethodParamPadCheck #14893

Merged
merged 1 commit into from
May 28, 2024
Merged

Issue #13675: add constructor call token to MethodParamPadCheck #14893

merged 1 commit into from
May 28, 2024

Conversation

strkkk
Copy link
Member

@strkkk strkkk commented May 23, 2024 •
edited
Loading

@strkkk
Copy link
Member Author

strkkk commented May 23, 2024

github, generate report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited by strkkk
Loading

Report (no space and with space):
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7e41632_2024025405/reports/diff/index.html

romani
romani approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

But please do one more report without with_space it produces bunch of noise. Better to keep them separately.

@romani romani requested a review from nrmancuso May 23, 2024 15:34
@strkkk
Copy link
Member Author

strkkk commented May 23, 2024

github, generate report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited by strkkk
Loading

Report (no space) https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/7e41632_2024203437/reports/diff/index.html

nrmancuso
nrmancuso requested changes May 26, 2024
View reviewed changes
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new test case with input similar to what is in the issue with constructor calls that have some arguments.

@strkkk
Copy link
Member Author

strkkk commented May 28, 2024

@nrmancuso done

@nrmancuso nrmancuso merged commit 73120c4 into checkstyle:master May 28, 2024
111 checks passed
@strkkk strkkk deleted the 13675_method_param_pad branch May 28, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@nrmancuso nrmancuso nrmancuso approved these changes

Assignees

@nrmancuso nrmancuso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodParamPad ignores explicit constructor invocation
3 participants
@strkkk @romani @nrmancuso