Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Feature Integration Document: JEPS #14923

Open
rnveach opened this issue Jun 1, 2024 · 2 comments
Open

Language Feature Integration Document: JEPS #14923

rnveach opened this issue Jun 1, 2024 · 2 comments
Assignees

Comments

@rnveach
Copy link
Member

rnveach commented Jun 1, 2024

Identified at #14904 (comment) ,

Probably JEPS should be first so the user understands what the new feature is before diving into examining existing checks.

Then looking at Review Associated JEP's Recommendations, it seems like we are splitting apart the same information.

Going with above, I think we should have a common review the JEPs and understand the change better, then updating and creating new checks can talk about their individual specifics that the global started their thinking process.

@nrmancuso
Copy link
Member

We can come back to this after some tracker issues have been completed and we have some more experience.

@mahfouz72
Copy link
Member

mahfouz72 commented Jun 22, 2024

We should also extend our check update docs to always consider this check when new keywords are added to the language.

leaving this for just a remainder

Edit from @nrmancuso: the check we are referring to is IllegallIdentifier

#15105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants