Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document WhitespaceAround for-each property #15

Merged
merged 1 commit into from Oct 6, 2013

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Oct 6, 2013

Follow up to 09f1ba2.

@romani
Copy link
Member

romani commented Oct 6, 2013

is it fix for certain problem ?
please provide link to original bug or .... , this is required to verify your changes.

@gaul
Copy link
Contributor Author

gaul commented Oct 6, 2013

The original commit lacked documentation, which made this functionality undiscoverable.

@romani
Copy link
Member

romani commented Oct 6, 2013

From where you grab that patch? Changes that aurhor can not explain will never be applied, sorry, it means for me that nobody need them.

@gaul
Copy link
Contributor Author

gaul commented Oct 6, 2013

@romani this commit documents an existing feature that was committed in 2011. My commit merely documents this functionality. Please read the referenced commit from my commit message.

@romani
Copy link
Member

romani commented Oct 6, 2013

sorry, I mixed up your changes and changes of Oleg (I did it from phone).

romani added a commit that referenced this pull request Oct 6, 2013
Document WhitespaceAround for-each property
@romani romani merged commit 64cd15d into checkstyle:master Oct 6, 2013
@gaul gaul deleted the whitespace-around-foreach branch October 7, 2013 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants