-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14937: Migrated section 3.4.2.1 Overloads: Never Split to follow Chapter Wise Testing approach #15031
Conversation
9dc46f0
to
4c23229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have at least one Input that have no violations ? like: InputCorrectOverloadsNeverSplit
all other Inputs can have violations and any name we like
we will use such Inputs to run google formatter to make sure we are not conflicting with it, files will be selected by pattern **/it/**/InputCorrect*
item:
CI is failing but it does not affect the PR |
I think we should do this when we're using With the current method we're only following some specific rules. If we run google formatter against these inputs then it will format all the bad code and it will be hard to find if we're following the style guide properly or not. |
Sounds good. We will do this as separate phase of updates. |
1922ffb
to
dda4228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
@rdiachenko , canceled jobs can be ignored for this PR. |
@Zopsss please fix conflicts |
a558d60
to
0437261
Compare
…it to follow Chapter Wise Testing approach
0437261
to
6b61ff5
Compare
@@ -335,7 +335,7 @@ | |||
</td> | |||
<td> | |||
<a href="styleguides/google-java-style-20220203/javaguide.html#s3.2-package-statement"> | |||
3.2 Package Statement</a> | |||
3.2 Package statement</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted all section names I modified in previous PRs to their original names. I added support to properly validate section names here: #15030 (comment). I forgot to revert section names in that PR so I did it here
@rdiachenko conflicts resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
issue #14937
migrated the section and added some new test cases in
records
input file