Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #14937: Migrated section 3.4.2.1 Overloads: Never Split to follow Chapter Wise Testing approach #15031

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Zopsss
Copy link
Contributor

@Zopsss Zopsss commented Jun 19, 2024

issue #14937

migrated the section and added some new test cases in records input file

src/xdocs/google_style.xml Outdated Show resolved Hide resolved
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have at least one Input that have no violations ? like: InputCorrectOverloadsNeverSplit

all other Inputs can have violations and any name we like
we will use such Inputs to run google formatter to make sure we are not conflicting with it, files will be selected by pattern **/it/**/InputCorrect*

item:

config/checkstyle-resources-suppressions.xml Outdated Show resolved Hide resolved
@romani romani self-assigned this Jun 19, 2024
@Zopsss
Copy link
Contributor Author

Zopsss commented Jun 19, 2024

@Zopsss
Copy link
Contributor Author

Zopsss commented Jun 19, 2024

Is it possible to have at least one Input that have no violations ? like: InputCorrectOverloadsNeverSplit

all other Inputs can have violations and any name we like we will use such Inputs to run google formatter to make sure we are not conflicting with it, files will be selected by pattern **/it/**/InputCorrect*

I think we should do this when we're using verifyWithWholeGoogleConfig() because then we will be following all the rules of google style.

With the current method we're only following some specific rules. If we run google formatter against these inputs then it will format all the bad code and it will be hard to find if we're following the style guide properly or not.

@romani
Copy link
Member

romani commented Jun 19, 2024

Sounds good. We will do this as separate phase of updates.

@Zopsss Zopsss force-pushed the overloads-never-split branch 2 times, most recently from 1922ffb to dda4228 Compare June 19, 2024 18:02
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested a review from rdiachenko June 19, 2024 18:36
@romani romani assigned rdiachenko and unassigned romani Jun 19, 2024
@romani
Copy link
Member

romani commented Jun 20, 2024

@rdiachenko , canceled jobs can be ignored for this PR.

@rdiachenko
Copy link
Contributor

@Zopsss please fix conflicts

@Zopsss Zopsss force-pushed the overloads-never-split branch 2 times, most recently from a558d60 to 0437261 Compare June 21, 2024 07:18
…it to follow Chapter Wise Testing approach
@@ -335,7 +335,7 @@
</td>
<td>
<a href="styleguides/google-java-style-20220203/javaguide.html#s3.2-package-statement">
3.2 Package Statement</a>
3.2 Package statement</a>
Copy link
Contributor Author

@Zopsss Zopsss Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted all section names I modified in previous PRs to their original names. I added support to properly validate section names here: #15030 (comment). I forgot to revert section names in that PR so I did it here

@Zopsss
Copy link
Contributor Author

Zopsss commented Jun 21, 2024

@rdiachenko conflicts resolved

Copy link
Contributor

@rdiachenko rdiachenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdiachenko rdiachenko merged commit dfb941b into checkstyle:master Jun 21, 2024
111 checks passed
@Zopsss Zopsss deleted the overloads-never-split branch June 22, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants