Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Huntbugs tool in our build process #3556

Closed
romani opened this issue Nov 16, 2016 · 5 comments
Closed

Use Huntbugs tool in our build process #3556

romani opened this issue Nov 16, 2016 · 5 comments

Comments

@romani
Copy link
Member

romani commented Nov 16, 2016

https://github.com/amaembo/huntbugs

we need to start to use it.

@Nimfadora
Copy link
Contributor

@romani I have a several concerns about this tool:

  1. Do you really want add it to checkstyle? Looks like currently it is dead (No updates for 9 month). And the majority of checks are taken from findbugs, as said in their manual:

Currently 222 FindBugs warnings reimplemented and several new warnings added.

  1. I took a closer look into ways to use in our project, and it happened to be not so easy.
    This tool analyses not the sources, but already compiled bytecode. And it gives a huge number of violations on antlr classes - around 95% of all violations.
    Thats why we will need somehow to ignore antlr classes. But it's maven plugin does not provide such functionality. It takes only one input directory and thats all.

@romani
Copy link
Member Author

romani commented Jun 26, 2017

@Nimfadora ,

Looks like currently it is dead (No updates for 9 month)

Findbugs is dead completely - http://findbugs.sourceforge.net/
The current version of FindBugs is 3.0.1, released on 13:05:33 EST, 06 March, 2015

I took a closer look into ways to use in our project, and it happened to be not so easy.
This tool analyses not the sources, but already compiled bytecode

the same as findbugs

It takes only one input directory and thats all.

sad, please contact project maintainers in gitter chat for details.
If no reply - create and issue on them to do some excludes for classes or implement suppression model to let at least suppress violations on certain classes.

If there is no suppression model , it is good reason to skip it. But issue has to be created on their issue tracker and link to it should be shared in this issue.

we do not have to use them by maven only. If they could be executed from CLI we could keep using them only on Travis. If tool is only for gradle, we could create for it fake gradle config and initiate gradle build that do only execution of this tool.

@romani romani moved this from To Do to In Progress in Practice What You Preach Jun 28, 2017
@Nimfadora
Copy link
Contributor

@romani , acording to reply in gitter, it looks like this tool will not be supported any longer. Should I create issue in github?

@rnveach
Copy link
Member

rnveach commented Jun 28, 2017

Gitter conversation and (rough) google translation:

Nimfadora
Привет, а хантбаг еще будет поддерживаться? Хотим использовать его в https://github.com/checkstyle/checkstyle , но нам не хватает возможности саппресить определенные ворнинги и более гибко настраивать какие классы он будет чекать...
Hello, and hantbag will still be supported? We want to use it in https://github.com/checkstyle/checkstyle, but we do not have enough opportunity to apply certain wins and more flexible to configure which classes it will check ...

Tagir Valeev
Привет! Маловероятно 😟
Можете форкать и забирать себе =)
Hello! Unlikely: worried:
You can forge and take yourself =)

@romani
Copy link
Member Author

romani commented Jun 28, 2017

From gitter at 20170628:

Nimfadora 07:17
Привет, а хантбаг еще будет поддерживаться? Хотим использовать его в https://github.com/checkstyle/checkstyle , но нам не хватает возможности саппресить определенные ворнинги и более гибко настраивать какие классы он будет чекать...

Tagir Valeev 07:24
Привет! Маловероятно 😟
Можете форкать и забирать себе =)

Maxim Degtyarev 08:06
ЖетБрейнс взяло тебя в рабство и времени теперь хватает только на то, чтобы поработать и поспать? )

Tagir Valeev 08:17
Ну пилить две похожие штуки одновременно явно странно
Лучше делать одну, но хорошо 😀

So, if you translate, you can see that tool is unlikely to be supported.
We should not use it too.

@romani romani closed this as completed Jun 28, 2017
@romani romani moved this from In Progress to Done in Practice What You Preach Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants