Xpath-Suppression is not working for Indentation

[Abhishek-kumar09]

generate-xpath-suppression is not working for Indentation.

$ cat config.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd">

<module name = "Checker">
    <module name="TreeWalker">
        <module name="Indentation">               
        </module>
    </module>
</module>

$ cat Test.java
class Test {
    void indentationTest() {
    int indent = 0;

    }
}

$ java -jar checkstyle-8.30-all.jar -g -c config.xml Test.java
Checkstyle ends with 1 errors.

All modules except Indentation can generate their xpath-suppression as usual.
A correctly generated XPath-suppression looks like :

$ cat config.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd">

<module name = "Checker">
    <module name="TreeWalker">
        <module name="NoWhitespaceBefore">               
        </module>
    </module>
</module>

$ Test.java
class Test {
  void otherTestIsWorking() {
    int whitespace = 0  ;
  }
}

$ java -jar checkstyle-8.30-all.jar -g -c config.xml Test.java
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE suppressions PUBLIC
    "-//Checkstyle//DTD SuppressionXpathFilter Experimental Configuration 1.2//EN"
    "https://checkstyle.org/dtds/suppressions_1_2_xpath_experimental.dtd">
<suppressions>
<suppress-xpath
       files="Test.java"
       checks="NoWhitespaceBeforeCheck"
       query="/CLASS_DEF[./IDENT[@text='Test']]/OBJBLOCK/METHOD_DEF[./IDENT[@text='otherTestIsWorking']]/SLIST/SEMI"/>
</suppressions>
Checkstyle ends with 1 errors.

[wltan]

I would generally expect this to be within the scope of #7734. We update to log DetailAST so that we can generate XPath suppression, not the other way around.

Your PR #8038 is still logging by line + column numbers and not DetailAST nodes, so there will of course be no XPath suppression. If you are having other difficulties, maybe you could elaborate a bit more on why it doesn't work?

[Abhishek-kumar09]

Thanks for your review @wltan, I am currently busy with another issue. I will definitely look to your valuable advice in #8038 ., till then I have changed it to draft. Thanks once again.

[Abhishek-kumar09]

I have updated the code to give the correct suppression results, I think the issue is worthless now and can be closed.