Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SARIF logs are annotated with endLine/endColumn in the ranges #1054

Closed
scalvert opened this issue Aug 30, 2021 · 1 comment
Closed

Ensure SARIF logs are annotated with endLine/endColumn in the ranges #1054

scalvert opened this issue Aug 30, 2021 · 1 comment
Labels
enhancement New feature or request
Projects
v1.0
Milestone
v1.0.0

Comments

@scalvert
Copy link
Contributor

Right now we don't output endLine/endColumn in the SARIF log for the artifact's physical location. We need to add this to ensure the log is complete.
@scalvert scalvert added this to the v1.0.0 milestone Aug 30, 2021
@scalvert
Copy link
Contributor Author

The physicalLocation is currently populated in BaseTask.addResult. If present, we should use endLine/endColumn. If not present, we should default those values to startLine/startColumn.

@scalvert scalvert added this to To do in v1.0 Aug 30, 2021
@scalvert scalvert added the enhancement New feature or request label Aug 30, 2021
@scalvert scalvert mentioned this issue Sep 4, 2021
Merged
@scalvert scalvert moved this from To do to In progress in v1.0 Sep 4, 2021
@scalvert scalvert moved this from In progress to Done in v1.0 Sep 4, 2021
@scalvert scalvert closed this as completed Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
v1.0
Done
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@scalvert