Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashtag shortcut from external instances include muted accounts #371

Open
eliocamp opened this issue Dec 20, 2023 · 8 comments
Open

Hashtag shortcut from external instances include muted accounts #371

eliocamp opened this issue Dec 20, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@eliocamp
Copy link

Describe the bug

As described in the title.

To Reproduce
Steps to reproduce the behaviour:

  1. Add a shortcut for a hashtag from your instance.
  2. Add a shortcut for the same hashtag but from an external instance.
  3. See a post that is in both columns and mute the user.
  4. Reload both columns. The post disappears on the first column but is there on the second one.

Expected behavior

Muted accounts should not be shown.

Screenshots

Shortcuts for the #argentina hashtag. One on mastodon.social (my instance) and the other on mas.to. Both show posts by the AllQuakes bot

2023-12-20_10-41

Muting the bot

2023-12-20_10-42

Now the posts are not there on the mastodon.social column but is still shown in the mas.to column.

2023-12-20_10-42_1

@cheeaun cheeaun added the enhancement New feature or request label Dec 20, 2023
@cheeaun
Copy link
Owner

cheeaun commented Dec 20, 2023

Muted accounts are stored in the back-end of your logged-in instance, not really a client-side setting. It doesn't work on the other instance.

@eliocamp
Copy link
Author

Ah, I was afraid that this might be not technically possible. Could phanpy retrieve and/or store the list of muted accounts and apply the filter itself? It might be too cumbersome and hard to maintain.

@cheeaun
Copy link
Owner

cheeaun commented Dec 21, 2023

Storing the list on client-side is… yeah, cumbersome 🙈

Some mobile apps are probably already doing it (e.g. Ivory with client-side filters, mutes, etc — I'm not sure if they also apply it on remote timelines) with offline⇔remote database sync. Phanpy doesn't have this kind of db + sync implementation yet. Mutes list can also be very long with paginated responses (I'm not sure what's the limit or if there's even a limit?)

@eliocamp
Copy link
Author

What if the user had a second account in the external instance? Would it be possible for the shortcut to fetch the hashtag usign that account and thus respecting its mute list? Perhaps this is a second feature request.

@cheeaun
Copy link
Owner

cheeaun commented Dec 22, 2023

@eliocamp if the user has an account on that instance and user has added the account on Phanpy, the mute list (from that instance) should work theoretically. Though the user will need to mute the same profile from both accounts.

Note that the posts are not hidden from the client-side by checking the mute list. It's the back-end/server that's doing the work, by not including the muted posts from the beginning.

@eliocamp
Copy link
Author

@eliocamp if the user has an account on that instance and user has added the account on Phanpy, the mute list (from that instance) should work theoretically. Though the user will need to mute the same profile from both accounts.

That's my case. I have an account on mastodon.social and one on sigmoid.social. If I add a shortcut on phanpy in my sogmoid.social that points to the mastodon.social instance, it doesn't use the mastodon.social mute list.

@cheeaun
Copy link
Owner

cheeaun commented Dec 23, 2023

If I add a shortcut on phanpy in my sogmoid.social that points to the mastodon.social instance, it doesn't use the mastodon.social mute list.

Yeah, you'll have to mute the same accounts on the other instance. Or… you could export/import the mute list between the instances… 🤔

@eliocamp
Copy link
Author

Or not. If I add the hashtag shortcut using that performs the request from another account, I can use that account mute list only and I don't need to keep them in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants