Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view full size profile photo #480

Closed
wakest opened this issue Apr 2, 2024 · 4 comments
Closed

view full size profile photo #480

wakest opened this issue Apr 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@wakest
Copy link

wakest commented Apr 2, 2024

I often go to a persons profile and click on their photo to enlarge it. not being able to see someones full size profile image by quickly clicking on it is quite confusing and catches me off guard quite often

heres what it looks like on Mastodon web
image

and heres the same in Elk
image

@wakest wakest added the enhancement New feature or request label Apr 2, 2024
@wakest
Copy link
Author

wakest commented Apr 3, 2024

ahhh I just saw this!
image

when did you add this? the only thing that would make it better is loading that image in a lightbox instead of a new window

@cheeaun
Copy link
Owner

cheeaun commented Apr 3, 2024

@wakest 12 hours ago 🙈 e3c25d2

Will be sticking with new window/tab. It's really minimum viable feature for now as the browser will auto-handle all the zoom and auto-fit of the image.

@wakest
Copy link
Author

wakest commented Apr 3, 2024

I am very impressed! Did you randomly start working on it 12 hours ago or was it because I posted this issue? The new tab/window thing works but on mobile PWA its quite jarring

@wakest wakest closed this as completed Apr 3, 2024
@cheeaun
Copy link
Owner

cheeaun commented Apr 4, 2024

@wakest I'm aware of this feature for some time, your issue randomly reminded me, it's pretty easy to add (without lightbox), the extra menu when clicking on the handle was already there to include this feature, and the timing was right.

I do get the jarring part, so will revisit this one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants