Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelfed posts with 5 or more photos cropped in weird dimention when logged in via Pixelfed account #490

Open
wakest opened this issue Apr 11, 2024 · 2 comments
Labels

Comments

@wakest
Copy link

wakest commented Apr 11, 2024

Phanpy displays the full amount of photos from the post when logged into via Pixelfed but depending on the screen width crops them to a strange dimension.

image

post in question: https://pixelfed.social/p/Lacalle/684124192137313050

the view from the search screen page (attached below) looks quite fine to me with adding 4+ on the forth photo and then loading the lightbox on click
image

tested on dev.phanpy.social (version)
Firefox 124.0.2 (64-bit)
macOS 13.6.4

@wakest
Copy link
Author

wakest commented Apr 11, 2024

I just noticed this view is also there when logged in from only a mastodon account but when looking at the remote Pixelfed timeline as well

@cheeaun
Copy link
Owner

cheeaun commented Apr 12, 2024

There's no design done yet for posts with >5 media attachments. Most styling work is optimized for Mastodon's limit of 4 media attachments. So, what we're seeing here is best-effort minimum-viable design 🙂

The "4+" thing was added to anticipate >4 media attachments, limit them and prevent them from taking too much space in the timeline, but show all on the post page.

As for the odd cropping, I'll need to figure out what's the best way to display them and think about various cases like:

  • Different dimensions. Edge case: very big or small images.
  • Different aspect ratios. Edge case: very tall/wide images.
  • Even/odd/max number of media attachments: Edge case: hundreds of images? (if any instance even allows it?)
  • Mixed list of video + audio + photo + unknowns (Also depends on the instance allowing it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants