Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j and k keyboard shortcuts not behaving as expected #500

Closed
mickaobrien opened this issue Apr 15, 2024 · 4 comments
Closed

j and k keyboard shortcuts not behaving as expected #500

mickaobrien opened this issue Apr 15, 2024 · 4 comments
Labels
bug Something isn't working keyboard-shortcuts

Comments

@mickaobrien
Copy link
Contributor

Describe the bug

  • Which site: dev.phanpy.social
  • Which site version: 2024.04.15.57390a2

On dev.phanpy.social, pressing:

  • j triggers the hotkey event twice and the focus moves to the status after next instead of the next one
  • k toggles cloak mode instead of moving the focus to the previous status

The other keyboard shortcuts seem to be working fine.

I just had a look locally and disabling useKey in useHotKeys (code) fixes these problems, but I'm not sure what the actual issue is.

Desktop:

  • OS: Ubuntu 22.04
  • Browsers: Firefox 124.0.2, Chrome 123.0.6312.105
@cheeaun
Copy link
Owner

cheeaun commented Apr 15, 2024

@mickaobrien may I know what's the keyboard you're using?

nevermind, I'm able to reproduce the bug. Will fix.

@wakest
Copy link

wakest commented Apr 17, 2024

just came across this one too on dev J/K navigation pretty borked

@cheeaun
Copy link
Owner

cheeaun commented Apr 17, 2024

@wakest @mickaobrien should be fixed in latest dev now.

@wakest
Copy link

wakest commented Apr 22, 2024

@cheeaun seems fixed to me too! shall we close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keyboard-shortcuts
Projects
None yet
Development

No branches or pull requests

3 participants