Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a release candidate 4? #1476

Closed
eklem opened this issue Sep 5, 2020 · 10 comments
Closed

Time for a release candidate 4? #1476

eklem opened this issue Sep 5, 2020 · 10 comments

Comments

@eklem
Copy link
Contributor

eklem commented Sep 5, 2020

Wouldn't it be good to create a 1.0.0-rc.4 branch and publish to NPM? This way we could get the security updates even if 1.0.0 is not finished yet.

@jessbowers-DSS
Copy link

is there an issue tracking the 1.0.0 release? What is left to be done?

@eklem
Copy link
Contributor Author

eklem commented Sep 8, 2020

Here it is, @jessbowers-DSS: https://github.com/cheeriojs/cheerio/projects/1
Or, it's a project =)

@eklem
Copy link
Contributor Author

eklem commented Oct 1, 2020

@matthewmueller, @fb55 or @jugglinmike ?

@eklem
Copy link
Contributor Author

eklem commented Oct 1, 2020

Made a pull request: #1499
Updated lodash to safe version and added the two working Dependabot updates too, from these PR's:

#1498
#1497

@eklem
Copy link
Contributor Author

eklem commented Oct 2, 2020

Thanks for the merging the PR @fb55! Would it be possible to push a new version to NPM too?

@TrySound
Copy link
Contributor

TrySound commented Oct 2, 2020

Btw we can try to get rid of lodash
#1500

@eklem
Copy link
Contributor Author

eklem commented Oct 2, 2020

I was thinking that just get security fixes out now, and then continue the work on final v1.0.0 without any hasty changes =)

@eklem
Copy link
Contributor Author

eklem commented Oct 3, 2020

Seems it's going to be a bit more substantial stuff added to rc.4: #1499 (comment), @TrySound =)

@fb55
Copy link
Member

fb55 commented Dec 15, 2020

Quick update here: I just opened #1564 and #1565. I'll keep them open for a few days to allow people to review. Once they are merged, I will cut a new RC.

@fb55
Copy link
Member

fb55 commented Dec 21, 2020

Published 1.0.0-rc.4!

@fb55 fb55 closed this as completed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants