Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting a new release to avoid deprecation warning #1717

Closed
JustinBeckwith opened this issue Feb 5, 2021 · 6 comments
Closed

Cutting a new release to avoid deprecation warning #1717

JustinBeckwith opened this issue Feb 5, 2021 · 6 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@JustinBeckwith
Copy link

Greetings folks - thank you for building a lovely library. When installing 1.0.0-rc.5, downstream users are getting a deprecation warning for cheerio-select-tmp, telling them to move to cheerio-select. I see that the change already landed on main, but I was wondering if we could maybe get an rc.6 :).

@starzou
Copy link

starzou commented Feb 9, 2021

I think so too.😊

@kevinvanrijn
Copy link

This was also requested on #1594 (comment) and then promptly ignored.

@5saviahv 5saviahv added the dependencies Pull requests that update a dependency file label Feb 16, 2021
@KenEucker
Copy link

KenEucker commented Mar 21, 2021

bumping this as it seems well within the ability of the cheeriojs team to address their own internal deprecations.

@karlhorky @5saviahv halp?

@fb55
Copy link
Member

fb55 commented Apr 8, 2021

Done!

@fb55 fb55 closed this as completed Apr 8, 2021
@EHadoux
Copy link

EHadoux commented Apr 9, 2021

Thanks for the new version! Does it mean that now PrevAll with a filter returns the list in the same order as JQuery (and thus in reversed compared to the previous version)? (see #1754) If that's the case, should it be mentioned as a BugFix or a Breaking Change? Cheers

@fb55
Copy link
Member

fb55 commented Apr 10, 2021

@EHadoux Thanks for flagging, updated the release notes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

7 participants