Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.find([cheerio Object]) fails #24

Closed
matthewmueller opened this issue Jan 7, 2012 · 2 comments
Closed

.find([cheerio Object]) fails #24

matthewmueller opened this issue Jan 7, 2012 · 2 comments

Comments

@matthewmueller
Copy link
Member

Example:

$script = $('script[type="text/javascript"]')
$('body').find($script); // fail!
@matthewmueller
Copy link
Member Author

Was hoping to close this one tonight, but this its going to take some more effort. jQuery uses the DOM's native compareDocumentPosition along with contains. Will need to implement something similar in order to resolve this bug.

@jugglinmike
Copy link
Member

Resolved via #529.

@matthewmueller According to my reading, we didn't need compareDocumentPosition-like functionality to implement this signature. Could you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants