Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for $("script, link, img") #4

Closed
matthewmueller opened this issue Nov 4, 2011 · 6 comments
Closed

Add support for $("script, link, img") #4

matthewmueller opened this issue Nov 4, 2011 · 6 comments

Comments

@matthewmueller
Copy link
Member

Being able to select multiple types of tags at once is immensely useful.

A few ways to implement this:

  • Monkey-patch soup-select for now, submit patch to author
  • Implement jQuery's .add() function and use that
  • Take a look at Sizzle engine, and see how difficult the port would be
@matthewmueller
Copy link
Member Author

Will be working on this now that soup-select has been forked

@siddMahen
Copy link

I think we should be able to close this if we update to the latest cheerio-soup select.

@matthewmueller
Copy link
Member Author

Good call. Let me publish it today (and figure out how to give you access to publish freely)

@siddMahen
Copy link

Thanks! Do you mean publishing via npm or publishing onto cheerio?

@matthewmueller
Copy link
Member Author

Okay, finally this can be closed. Thanks.

I wasn't sure how to add you as a publisher in NPM, but I added you as a contributor in cheerio.

@siddMahen
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants