-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser doesn't work correctly if greater than appears in attribute value #62
Comments
Yikes... any idea when this will be fixed? I'm evaluating using cheerio in DocPad for some of the plugins, but this seems scary. |
HI Guys, I have noticed the same problem myself. In particular where any HTML is stored inside and attribute. So credit tags in a title attribute get parsed instead of being escaped and ignored. Thanks Great work by the way, cheerio is fantastic. |
+1 |
@matthewmueller ping. This is a huge problem for projects that uses two-way data-binding solutions like Angular/Knockout/etc which does inline logic. |
Yes. We use knockout and it was a big issue. I ended up having to write a pre-processor to update them to HTML entities. It wasn't crazy hard, but a little complicated. I would release the code if I could, but my company owns it. |
this is a known issue and it's being tracked here: https://github.com/fb55/node-htmlparser/issues/14 |
<div class="add-question first" data-bind="visible: questionSets()[0].questions().length > 0">
If I read that in with cheerio and get the html, the tag ends at the first greater than sign.
Chris
The text was updated successfully, but these errors were encountered: