Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERB processing only applies to FigNewton.load('filename') #12

Closed
azohra opened this issue Dec 20, 2015 · 1 comment
Closed

ERB processing only applies to FigNewton.load('filename') #12

azohra opened this issue Dec 20, 2015 · 1 comment

Comments

@azohra
Copy link
Contributor

azohra commented Dec 20, 2015

Hey @cheezy , I noticed today that loading via ENV does not support ERB. When you use FigNewton.load, the YAML is handled by your yml_reader gem which does ERB interpolation. When you use ENV['FIG_NEWTON_FILE'], FigNewton loads the yaml within itself and that method has no ERB interpolation.

I would suggest that FigNewton always call the yml_reader .load method to ensure parity regardless of entry point. yml_reader is included as a dependancy on FigNewton so this should be a quick win.

# ERB processed
FigNewton.load('data.yml')  
# Non ERB processed
ENV['FIG_NEWTON_FILE']='data.yml'
@cheezy
Copy link
Owner

cheezy commented Sep 23, 2017

Done my friend! :)

@cheezy cheezy closed this as completed Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants