Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate foodcritic quality metric QM009 in favor of QM008 #66

Open
sam1el opened this issue Feb 28, 2020 · 2 comments
Open

Deprecate foodcritic quality metric QM009 in favor of QM008 #66

sam1el opened this issue Feb 28, 2020 · 2 comments

Comments

@sam1el
Copy link

sam1el commented Feb 28, 2020

Supermarket is still using foodcritic as a metric which is no longer best practice.

Describe the problem

Foodcritic is essentially fully deprecated. We should be using cookstyle which is the best practice we give customers.
I also feel this would help us to identify severely broken and deprecated cookbooks.

Software Version

This is specific to public supermarket

Possible Solution

Replace QM009 with QM008

@tas50
Copy link
Contributor

tas50 commented Feb 28, 2020

Yea @robbkidd and I would both love to switch over to Cookstyle for the quality metrics, but that's a non-trivial amount of work.

@sam1el
Copy link
Author

sam1el commented Feb 28, 2020

yeah, I was just looking at the supermarket code. looks pretty heavy. I may dig at it a bit and see what I can come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants