Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output and status commands don't do proper input validation #57

Open
juliandunn opened this issue Dec 14, 2016 · 0 comments
Open

output and status commands don't do proper input validation #57

juliandunn opened this issue Dec 14, 2016 · 0 comments
Labels
Type: Bug Doesn't work as expected.

Comments

@juliandunn
Copy link

juliandunn commented Dec 14, 2016 •
edited

Version:

knife push 1.0.2

Environment:

ChefDK 1.0.3

Scenario:

The knife job output and knife job status commands do not do proper input validation (i.e. require job ID and/or node). Because these arguments are not enforced, an empty value is passed to the Push Jobs API and then it returns a 404.

Steps to Reproduce:

Type knife job output without specifying a job ID or a node.

Expected Result:

It should tell me that I need to specify the correct arguments.

Actual Result:

Because the arguments are not validated, knife-push blindly makes an API call to https://chefserver.lxc/organizations/demo/pushy/jobs//output//stdout (note how it has not filled in the job ID and node name) which returns a 404 to the user.

ERROR: The object you are looking for could not be found                  │
Response: <HTML><HEAD><TITLE>404 Not Found</TITLE></HEAD><BODY><H1>Not Fou│
nd</H1>The requested document was not found on this server.<P><HR><ADDRESS│
>mochiweb+webmachine web server</ADDRESS></BODY></HTML>
@tas50 tas50 added the Type: Bug Doesn't work as expected. label Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Doesn't work as expected.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliandunn @tas50