Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fullpath for xcopy and icacls. #152

Merged

Conversation

Projects
None yet
3 participants
@buri17
Copy link
Contributor

commented May 28, 2016

The current implementation doesn't specify full path of xcopy and icacls.

If the environment attributes is not specified or the PATH environment variable in the environment hash doesn't contain %SystemRoot%\System32, the invocations of the commands will fail.

@buri17 buri17 force-pushed the buri17:use_full_path_for_windows_commmands branch 3 times, most recently from 0466df4 to 75aafb1 May 28, 2016

@chef-supermarket

This comment has been minimized.

Copy link

commented May 28, 2016

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@buri17 buri17 force-pushed the buri17:use_full_path_for_windows_commmands branch 3 times, most recently from d3b049a to f0eb0e6 May 28, 2016

@chef-supermarket

This comment has been minimized.

Copy link

commented May 28, 2016

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@buri17 buri17 force-pushed the buri17:use_full_path_for_windows_commmands branch from f0eb0e6 to 4363942 May 28, 2016

@tas50 tas50 merged commit 724d902 into chef-cookbooks:master May 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tas50

This comment has been minimized.

Copy link
Member

commented May 29, 2016

Nice addition. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.