Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json-file location to README #270

Merged
merged 2 commits into from Aug 29, 2017

Conversation

adamleff
Copy link
Contributor

@adamleff adamleff commented Aug 29, 2017

Add the location of the json-file output to the README so people don't
have to go a-huntin' through the code to find the location.

Also fix a test that's failing in Travis due to the InSpec version being embedded in Chef omnibus since Chef 13.

Fixes #269

Add the location of the json-file output to the README so people don't
have to go a-huntin' through the code to find the location.

Signed-off-by: Adam Leff <adam@leff.co>
Since InSpec is included with the Chef omnibus build, we don't need to check
the version matches the chef attributes since it defaults to nil.

Signed-off-by: Adam Leff <adam@leff.co>
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not one of the requested approvers, but acknowledging that I took a look at this and it LGTM.

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adamleff !!

@arlimus arlimus merged commit e2cbf24 into master Aug 29, 2017
@arlimus arlimus deleted the adamleff/add-json-file-location-to-readme branch August 29, 2017 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document location of json reports when reporter is json-file
3 participants