[test me] compile_time works with Chef 11/12 including chef-sugar #110

scalp42 · 2015-02-19T07:02:23Z

The test recipe is the following (please note that this is the patched aws from this PR, with a little difference to trigger warning, see below):

include_recipe 'chef-sugar'
include_recipe 'aws'

chef_gem patched code (compile_time is not set to anything to trigger the warning):

chef_gem 'aws-sdk' do
  version node['aws']['aws_sdk_version']
  if Chef::Resource::ChefGem.instance_methods(false).include?(:compile_time)
    compile_time
  end
  action :install
end

Here are my results:

Chef 12.1.0.dev.0, without specifying true, just compile_time to show the warning :

==> zs1: [2015-02-19T06:47:57+00:00] INFO: Forking chef instance to converge...
==> zs1: [2015-02-19T06:47:57+00:00] INFO: *** Chef 12.1.0.dev.0 ***
==> zs1: [2015-02-19T06:47:57+00:00] INFO: Chef-client pid: 14440
==> zs1: [2015-02-19T06:48:15+00:00] WARN: chef_gem[chef-sugar] chef_gem compile_time installation is deprecated
==> zs1: [2015-02-19T06:48:15+00:00] WARN: chef_gem[chef-sugar] Please set `compile_time false` on the resource to use the new behavior.
==> zs1: [2015-02-19T06:48:15+00:00] WARN: chef_gem[chef-sugar] or set `compile_time true` on the resource if compile_time behavior is required.
==> zs1: [2015-02-19T06:48:23+00:00] INFO: chef_gem[chef-sugar] installed chef-sugar at 2.5.0
==> zs1: [2015-02-19T06:48:23+00:00] WARN: chef_gem[aws-sdk] chef_gem compile_time installation is deprecated
==> zs1: [2015-02-19T06:48:23+00:00] WARN: chef_gem[aws-sdk] Please set `compile_time false` on the resource to use the new behavior.
==> zs1: [2015-02-19T06:48:23+00:00] WARN: chef_gem[aws-sdk] or set `compile_time true` on the resource if compile_time behavior is required.
==> zs1: [2015-02-19T06:48:31+00:00] INFO: chef_gem[aws-sdk] installed aws-sdk at ~> 2.0.22
==> zs1: [2015-02-19T06:48:32+00:00] INFO: Chef Run complete in 28.265871351 seconds

Chef 12.0.3, don't see any log, but both gems are installed:

==> zs1: [2015-02-19T06:53:56+00:00] INFO: *** Chef 12.0.3 ***
==> zs1: [2015-02-19T06:53:56+00:00] INFO: Chef-client pid: 14938
==> zs1: [2015-02-19T06:54:24+00:00] INFO: Chef Run complete in 20.955133524 seconds

root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep chef
chef (12.0.3)
chef-sugar (2.5.0)
chef-zero (3.2.1)
root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep aws
aws-sdk (2.0.26)
aws-sdk-core (2.0.26)
aws-sdk-resources (2.0.26)

Chef 11.16.4, don't see any log, but both gems are installed:

==> zs1: [2015-02-19T06:56:38+00:00] INFO: *** Chef 11.16.4 ***
==> zs1: [2015-02-19T06:56:38+00:00] INFO: Chef-client pid: 15433
==> zs1: /var/chef/cache/cookbooks/homebrew/libraries/homebrew_package.rb:26: warning: toplevel constant Homebrew referenced by Chef::Provider::Package::Homebrew
==> zs1: [2015-02-19T06:57:47+00:00] INFO: Chef Run complete in 25.402963436 seconds

root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep chef
chef (11.16.4)
chef-sugar (2.5.0)
chef-zero (2.2)
root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep aws
aws-sdk (2.0.26)
aws-sdk-core (2.0.26)
aws-sdk-resources (2.0.26)

Chef 11.18.6, don't see any log, but both gems are installed:

==> zs1: [2015-02-19T06:58:47+00:00] INFO: *** Chef 11.18.6 ***
==> zs1: [2015-02-19T06:58:47+00:00] INFO: Chef-client pid: 16297
==> zs1: /var/chef/cache/cookbooks/homebrew/libraries/homebrew_package.rb:26: warning: toplevel constant Homebrew referenced by Chef::Provider::Package::Homebrew
==> zs1: [2015-02-19T06:59:22+00:00] INFO: Chef Run complete in 27.925290915 seconds

root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep chef
chef (11.18.6)
chef-sugar (2.5.0)
chef-zero (2.2.1)
root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep aws
aws-sdk (2.0.26)
aws-sdk-core (2.0.26)
aws-sdk-resources (2.0.26)

I also tried with chef_12.2.0-alpha.0-1_amd64.deb (which does not support compile_time):

==> zs1: [2015-02-19T07:00:55+00:00] INFO: *** Chef 12.2.0.alpha.0 ***
==> zs1: [2015-02-19T07:00:55+00:00] INFO: Chef-client pid: 16759
==> zs1: [2015-02-19T07:01:41+00:00] INFO: Starting audit phase
==> zs1: [2015-02-19T07:01:42+00:00] INFO: Successfully executed all controls blocks and contained examples
==> zs1:
==> zs1: Finished in 0.00018 seconds (files took 0.35235 seconds to load)
==> zs1: 0 examples, 0 failures
==> zs1: [2015-02-19T07:01:42+00:00] INFO: Chef Run complete in 39.759534584 seconds

root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep chef
chef (12.2.0.alpha.0)
chef-sugar (2.5.0)
chef-zero (3.2)
root@mesosphere-scalp-vagrant-vbox-1:~# /opt/chef/embedded/bin/gem list | grep aws
aws-sdk (2.0.26)
aws-sdk-core (2.0.26)
aws-sdk-resources (2.0.26)

I'm mostly breaking "something" as I don't see the resource being listed in the log but hopefully it helps.

sethvargo · 2015-02-19T15:30:40Z

recipes/default.rb

@@ -18,6 +18,7 @@
 #
 chef_gem 'aws-sdk' do
  version node['aws']['aws_sdk_version']
+  compile_time true if Chef::Resource::ChefGem.instance_methods(false).include?(:compile_time)


method_defined? is a better check here (and more efficient)

It doesn't work with method_defined?.

Chef 11.18.6

==> zs1: ================================================================================ ==> zs1: Recipe Compile Error in /var/chef/cache/cookbooks/mesosphere/recipes/test.rb ==> zs1: ================================================================================ ==> zs1: ==> zs1: ==> zs1: ArgumentError ==> zs1: ------------- ==> zs1: block not supplied ==> zs1: ==> zs1: ==> zs1: Cookbook Trace: ==> zs1: --------------- ==> zs1: /var/chef/cache/cookbooks/aws/recipes/default.rb:22:in `block in from_file' ==> zs1: ==> zs1: /var/chef/cache/cookbooks/aws/recipes/default.rb:19:in `from_file' ==> zs1: ==> zs1: /var/chef/cache/cookbooks/mesosphere/recipes/test.rb:3:in `from_file' ==> zs1: ==> zs1: ==> zs1: Relevant File Content: ==> zs1: ---------------------- ==> zs1: /var/chef/cache/cookbooks/aws/recipes/default.rb: ==> zs1: ==> zs1: 15: # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. ==> zs1: 16: # See the License for the specific language governing permissions and ==> zs1: 17: # limitations under the License. ==> zs1: 18: # ==> zs1: 19: chef_gem 'aws-sdk' do ==> zs1: 20: version node['aws']['aws_sdk_version'] ==> zs1: 21: if Chef::Resource::ChefGem.method_defined?(:compile_time) ==> zs1: 22>> compile_time ==> zs1: 23: end ==> zs1: 24: action :install ==> zs1: 25: end ==> zs1: 26: ==> zs1: 27: require 'aws-sdk' ==> zs1: 28: ==> zs1:

sethvargo · 2015-02-19T18:57:28Z

@scalp42 you need to provide a value for compile_time I think

martinisoft · 2015-02-24T04:35:01Z

@scalp42 as @sethvargo mentioned you need to provide true to compile_time as an argument there.

jtimberman · 2015-03-20T04:40:45Z

This is essentially the same fix as chef-boneyard/chef-vault@4739a65 - because I stole this for that one (thanks @scalp42!).

[test me] compile_time works with Chef 11/12 including chef-sugar

sethvargo · 2015-03-20T14:52:23Z

For the record, I have renamed the function in Chef Sugar v3.0.1 to at_compile_time to avoid the conflict.

scalp42 · 2015-03-20T18:01:40Z

Thanks @sethvargo for reconsidering it.

not entirely sure what's going on here, but i've backported some code from sous-chefs/aws#110 and chef-cookbooks/xml#22

compile_time works with Chef 11/12 including chef-sugar

651dd7b

chef-supermarket added the Signed CLA label Feb 19, 2015

This was referenced Feb 19, 2015

Wrong argument error in Chef 11.16.4 on 2.6.2 release #108

Closed

make sure to check the resource/provider classes instead of Chef::Recipe #109

Closed

scalp42 changed the title ~~compile_time works with Chef 11/12 including chef-sugar~~ [test me] compile_time works with Chef 11/12 including chef-sugar Feb 19, 2015

sethvargo reviewed Feb 19, 2015
View reviewed changes

jtimberman added a commit that referenced this pull request Mar 20, 2015

Merge pull request #110 from scalp42/fix_chef_12_compile_time

712bff8

[test me] compile_time works with Chef 11/12 including chef-sugar

jtimberman merged commit 712bff8 into sous-chefs:master Mar 20, 2015

scalp42 mentioned this pull request May 8, 2015

Bye, bye nokogiri! Use aws-sdk instead (WIP chef-boneyard/route53#70

Closed

scalp42 mentioned this pull request Jul 12, 2015

Add sensitive to certain file creation calls sensu/sensu-chef#351

Merged

scalp42 mentioned this pull request Nov 4, 2015

Added "compile_time false if respond_to?(:compile_time)" sous-chefs/lvm#72

Closed

scalp42 deleted the fix_chef_12_compile_time branch November 4, 2015 21:09

rxbynerd added a commit to rentify/letsencrypt that referenced this pull request Feb 11, 2016

backport for chef 11

e840d05

not entirely sure what's going on here, but i've backported some code from sous-chefs/aws#110 and chef-cookbooks/xml#22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test me] compile_time works with Chef 11/12 including chef-sugar #110

[test me] compile_time works with Chef 11/12 including chef-sugar #110

scalp42 commented Feb 19, 2015

sethvargo Feb 19, 2015

scalp42 Feb 19, 2015

sethvargo commented Feb 19, 2015

martinisoft commented Feb 24, 2015

jtimberman commented Mar 20, 2015

sethvargo commented Mar 20, 2015

scalp42 commented Mar 20, 2015

[test me] compile_time works with Chef 11/12 including chef-sugar #110

[test me] compile_time works with Chef 11/12 including chef-sugar #110

Conversation

scalp42 commented Feb 19, 2015

sethvargo Feb 19, 2015

Choose a reason for hiding this comment

scalp42 Feb 19, 2015

Choose a reason for hiding this comment

sethvargo commented Feb 19, 2015

martinisoft commented Feb 24, 2015

jtimberman commented Mar 20, 2015

sethvargo commented Mar 20, 2015

scalp42 commented Mar 20, 2015