Elastic lb provider fix - does not run deregister, always tries to register #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2015 15:44
target_lb[:instances] returns a list of nodes in the ELB. This needs to use detect for iteration so that it can discover the instance_id and determine whether or not the instance is actually inside the ELB. Without this fix, the current behavior has the deregister action never running and the register action always running.
Need to change 'with' to from, see the docs for the method: http://docs.aws.amazon.com/sdkforruby/api/Aws/ElasticLoadBalancing/Client.html#deregister_instances_from_load_balancer-instance_method
|
+1 It looks good to me. |
|
LGTM |
|
👍 |
miketheman
added a commit
that referenced
this pull request
Jun 28, 2015
Elastic lb provider fix - does not run deregister, always tries to register
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #132
This allows the deregister action to actually run and prevents the register action from running if the node is currently in the ELB.