Allow for systems with that do not have lsb installed #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update lsb codename to allow cookbooks with dependencies on erlang to still compile even if run on non lsb enabled systems.
|
I'm getting bitten by this too and have to run a local fork to keep the cookbook from breaking my Mac OS X machines. Any chance of getting this merged soon? |
|
We've run into this as well at Dyn on FreeBSD. Not directly using this cookbook but when it's in some unused dependency in our cookbooks that are on our FreeBSD systems. |
|
Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA. The following GitHub users do not appear to have signed a CLA: |
|
@someara same bug as what you fixed in the ubuntu cookbook today |
someara
pushed a commit
that referenced
this pull request
Jul 29, 2014
Allow for systems with that do not have lsb installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows for a system that doesn't have LSB installed you get the following error undefined method `[]' for nil:NilClass. This is especially useful if this cookbook is a dependency for another cookbook that runs on windows.