correcting all syntax issue #238
Conversation
Signed-off-by: Jeff Brimager <jbrimager@chef.io>
| @@ -26,8 +26,6 @@ def hab(*command) | |||
|
|
|||
| if Gem::Requirement.new('>= 14.3.20').satisfied_by?(Gem::Version.new(Chef::VERSION)) | |||
There was a problem hiding this comment.
If you're taking out the else here you should just take this whole thing out and require Chef 14.3. If you want to support 14.3 then put a cookstyle comment on that line to avoid the alert
There was a problem hiding this comment.
okay, I wasn't sure, currently the cookbook supports back to client 12.20 and I didn't want to break any of it. would any of these changes effect that?
There was a problem hiding this comment.
You'll want to turn that cop off with a comment then.
There was a problem hiding this comment.
ok has that syntax changed from the foodcritic method?
Signed-off-by: Jeff Brimager <jbrimager@chef.io>
spec/unit/sup_spec.rb
Outdated
| # context 'a Sysvinit platform' do | ||
| # cached(:chef_run) do | ||
| # ChefSpec::ServerRunner.new( | ||
| # step_into: ['hab_sup'], |
There was a problem hiding this comment.
You can probably change this to RHEL 6 if you need a sys-v platform
There was a problem hiding this comment.
I do, was going to verify if we had a rhel 6 first
There was a problem hiding this comment.
https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md
Make sure to use the major versions only so use 6 not 6.9
There was a problem hiding this comment.
only took me til this morning to get these fixed correctly lol will have them pushed in soon
…rhel 6 rather than debian for sysvinit Signed-off-by: Jeff Brimager <jbrimager@chef.io>
Obvious fix; these changes are the result of automation not creative thinking.
Signed-off-by: Jeff Brimager jbrimager@chef.io
Making sure all cookstyle errors are cleared
Description
cookstyle errors have exposed build issues. making required corrections
Issues Resolved
Builds should complete.
Check List