Changing logic to enable use of named instances #19
Conversation
This change enables the creation of named instances (e.g. MSSQL$MYINSTANCE). Before you could only have a default instance if your not using SQLEXPRESS.
|
@someara any change you could merge this one? Seems to me like a very small, non intrusive change that extends the usability quite nicely... |
|
@someara any update at all would be appreciated at this time... If there are any issues with this PR then please let me know so I can update/fix them and we can merge in this reasonable simple, but very useful PR. Thx! |
|
@someara last one... Again what's up with this? Any reason why this PR and my cry for attention is just being ignored? I have these 3 PR's (which I all just updated with this comment) open for months and months. So please make my day and merge and release these PR's (both this one and two with the database cookbook)... Thanks! |
|
@tas50 any change you can have a look at this one as well? |
|
Sorry for the late response. I'm working on this cookbook now and I'll get to checking this out soon. |
|
This change is quite useful for us too; maybe @svanharmelen you could rebase it to help @tas50 to merge it. |
|
@Annih this change is actually already in master: https://github.com/chef-cookbooks/sql_server/blob/master/recipes/server.rb#L23-L27 It's coded slightly different, but the result is exactly the same. So I'll close this PR as it has no value anymore 😀 |
|
I would disagree, this change is not equivalent at all, because it implies that my service won't be prefixed by "MSSQL" or that my instance name has to be prefixed by "MSSQL" if I want my service to be prefixed. I'll maybe open a new PR, with a new attribute for ServiceName; I'll see. Thanks for the update ;) |
This change enables the creation of named instances (e.g.
MSSQL$MYINSTANCE). Before you could only have a default instance if
your not using SQLEXPRESS.