-
Notifications
You must be signed in to change notification settings - Fork 111
/
role.go
308 lines (255 loc) · 7.44 KB
/
role.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
package postgres
import (
"context"
"github.com/lib/pq"
"github.com/pkg/errors"
"github.com/chef/automate/components/authz-service/storage"
"github.com/chef/automate/lib/grpc/auth_context"
"github.com/chef/automate/lib/projectassignment"
)
func (p *pg) CreateRole(ctx context.Context, role *storage.Role, skipProjectsCheckOnV1PolicyMigration bool) (*storage.Role, error) {
ctx, cancel := context.WithCancel(ctx)
defer cancel()
tx, err := p.db.BeginTx(ctx, nil /* use driver default */)
if err != nil {
return nil, p.processError(err)
}
projects := role.Projects
// ensure initial chef-managed policies/roles created
if !skipProjectsCheckOnV1PolicyMigration && role.Type == storage.Custom {
err = p.ensureNoProjectsMissingWithQuerier(ctx, tx, role.Projects)
if err != nil {
return nil, p.processError(err)
}
err = projectassignment.AuthorizeProjectAssignment(ctx,
p.engine,
auth_context.FromContext(auth_context.FromIncomingMetadata(ctx)).Subjects,
[]string{},
projects,
false)
if err != nil {
return nil, p.processError(err)
}
}
err = p.insertRoleWithQuerier(ctx, role, tx)
if err != nil {
return nil, p.processError(err)
}
err = p.notifyPolicyChange(ctx, tx)
if err != nil {
return nil, p.processError(err)
}
err = tx.Commit()
if err != nil {
return nil, storage.NewTxCommitError(err)
}
return role, nil
}
func (p *pg) ListRoles(ctx context.Context) ([]*storage.Role, error) {
projectsFilter, err := projectsListFromContext(ctx)
if err != nil {
return nil, err
}
var roles []*storage.Role
rows, err := p.db.QueryContext(ctx, "SELECT query_roles($1)", pq.Array(projectsFilter))
if err != nil {
return nil, p.processError(err)
}
defer func() {
if err := rows.Close(); err != nil {
p.logger.Warnf("failed to close db rows: %s", err.Error())
}
}()
for rows.Next() {
var role storage.Role
if err := rows.Scan(&role); err != nil {
return nil, p.processError(err)
}
roles = append(roles, &role)
}
if err := rows.Err(); err != nil {
return nil, errors.Wrap(err, "error retrieving result rows")
}
return roles, nil
}
func (p *pg) GetRole(ctx context.Context, id string) (*storage.Role, error) {
ctx, cancel := context.WithCancel(ctx)
defer cancel()
projectsFilter, err := projectsListFromContext(ctx)
if err != nil {
return nil, err
}
tx, err := p.db.BeginTx(ctx, nil /* use driver default */)
if err != nil {
return nil, p.processError(err)
}
doesIntersect, err := checkIfRoleIntersectsProjectsFilter(ctx, tx, id, projectsFilter)
if err != nil {
return nil, p.processError(err)
}
if !doesIntersect {
return nil, storage.ErrNotFound
}
var role storage.Role
row := tx.QueryRowContext(ctx, `SELECT query_role($1);`, id)
err = row.Scan(&role)
if err != nil {
return nil, p.processError(err)
}
err = tx.Commit()
if err != nil {
return nil, storage.NewTxCommitError(err)
}
return &role, nil
}
func (p *pg) DeleteRole(ctx context.Context, id string) error {
ctx, cancel := context.WithCancel(ctx)
defer cancel()
projectsFilter, err := projectsListFromContext(ctx)
if err != nil {
return err
}
tx, err := p.db.BeginTx(ctx, nil /* use driver default */)
if err != nil {
return p.processError(err)
}
doesIntersect, err := checkIfRoleIntersectsProjectsFilter(ctx, tx, id, projectsFilter)
if err != nil {
return p.processError(err)
}
if !doesIntersect {
return storage.ErrNotFound
}
res, err := tx.ExecContext(ctx, "DELETE FROM iam_roles WHERE id=$1", id)
if err != nil {
return p.processError(err)
}
err = p.singleRowResultOrNotFoundErr(res)
if err != nil {
return err
}
err = p.notifyPolicyChange(ctx, tx)
if err != nil {
return p.processError(err)
}
err = tx.Commit()
if err != nil {
return storage.NewTxCommitError(err)
}
return nil
}
func (p *pg) UpdateRole(ctx context.Context, role *storage.Role) (*storage.Role, error) {
ctx, cancel := context.WithCancel(ctx)
defer cancel()
projectsFilter, err := projectsListFromContext(ctx)
if err != nil {
return nil, err
}
tx, err := p.db.BeginTx(ctx, nil /* use driver default */)
if err != nil {
return nil, p.processError(err)
}
doesIntersect, err := checkIfRoleIntersectsProjectsFilter(ctx, tx, role.ID, projectsFilter)
if err != nil {
return nil, p.processError(err)
}
if !doesIntersect {
return nil, storage.ErrNotFound
}
newProjects := role.Projects
var oldRole storage.Role
// get the old role and lock the role for updates (still readable)
// until the update completes or the transaction fails so that
// the project diff doesn't change under us while we perform permission checks.
queryRoleRow := tx.QueryRowContext(ctx, `SELECT query_role($1) FOR UPDATE;`, role.ID)
err = queryRoleRow.Scan(&oldRole)
if err != nil {
return nil, p.processError(err)
}
err = p.ensureNoProjectsMissingWithQuerier(ctx, tx, newProjects)
if err != nil {
return nil, p.processError(err)
}
err = projectassignment.AuthorizeProjectAssignment(ctx,
p.engine,
auth_context.FromContext(auth_context.FromIncomingMetadata(ctx)).Subjects,
oldRole.Projects,
newProjects,
true)
if err != nil {
return nil, p.processError(err)
}
row := tx.QueryRowContext(ctx,
`UPDATE iam_roles SET (name, actions) =
($2, $3) WHERE id = $1 RETURNING db_id`,
role.ID, role.Name, pq.Array(role.Actions),
)
// TODO: check not found case
var dbID string
if err := row.Scan(&dbID); err != nil {
return nil, p.processError(err)
}
_, err = tx.ExecContext(ctx,
"DELETE FROM iam_role_projects WHERE role_id=$1", dbID)
if err != nil {
return nil, p.processError(err)
}
_, err = tx.ExecContext(ctx,
`INSERT INTO iam_role_projects (role_id, project_id)
SELECT $1, db_id FROM iam_projects WHERE id=ANY($2)`,
dbID, pq.Array(role.Projects))
if err != nil {
return nil, p.processError(err)
}
err = p.notifyPolicyChange(ctx, tx)
if err != nil {
return nil, p.processError(err)
}
err = tx.Commit()
if err != nil {
return nil, storage.NewTxCommitError(err)
}
return role, nil
}
func checkIfRoleIntersectsProjectsFilter(ctx context.Context, q Querier,
id string, projectsFilter []string) (bool, error) {
// If no filter was specified, do not filter.
if len(projectsFilter) == 0 {
return true, nil
}
// Return true or false if there is intersection between iam_role_projects and projectsFilter,
// assuming '{(unassigned)}' in the case that iam_role_projects is empty. If a role of id
// doesn't exist, this will return a proper SQL "no rows" error when passed to processError.
row := q.QueryRowContext(ctx, "SELECT COALESCE(projects_match(role_projects($1), $2), false)", id, pq.Array(projectsFilter))
var result bool
err := row.Scan(&result)
if err != nil {
return false, err
}
return result, nil
}
func (p *pg) insertRoleWithQuerier(ctx context.Context, role *storage.Role, q Querier) error {
tx, err := p.db.BeginTx(ctx, nil /* use driver default */)
if err != nil {
return p.processError(err)
}
row := q.QueryRowContext(ctx, `INSERT INTO iam_roles (id, name, type, actions) VALUES ($1, $2, $3, $4)
RETURNING db_id`,
role.ID, role.Name, role.Type.String(), pq.Array(role.Actions))
var dbID string
if err := row.Scan(&dbID); err != nil {
return p.processError(err)
}
_, err = q.ExecContext(ctx,
`INSERT INTO iam_role_projects (role_id, project_id)
SELECT $1, project_db_id(p) FROM unnest($2::TEXT[]) as p`,
dbID, pq.Array(role.Projects))
if err != nil {
return p.processError(err)
}
err = tx.Commit()
if err != nil {
return storage.NewTxCommitError(err)
}
return nil
}