Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chef Automate Apps tab capitalizes all channels #3626

Closed
ericcalabretta opened this issue May 9, 2020 · 2 comments · Fixed by #3650
Closed

Chef Automate Apps tab capitalizes all channels #3626

ericcalabretta opened this issue May 9, 2020 · 2 comments · Fixed by #3650
Assignees
Labels
automate-ui bug 🐛 Something isn't working ui

Comments

@ericcalabretta
Copy link

Describe the bug

Habitat channels can be uppercase and lowercase. The Automate Application tab dashboard uppercases all channels even if their real value us lowercase.

for example channel rb_prod is changed to RB_PROD

This causes Automate to report the incorrect channel in the web interface & you could potential mix up a lower & uppercase channel.

To Reproduce

Create a channel with a lower case value and configure reporting to the Automate applications tab

hab pkg channels eric/national-parks/8.0.0/20200509192449
» Retrieving channels for eric/national-parks/8.0.0/20200509192449 (x86_64-linux)
unstable
rb_prod

Expected behavior

Automate should respect the case of the channel. Lowercase and uppercase characters are both valid for channels & should be reported correctly in Automate.

Screenshots

The channel in this example actually is rb_prod but is reported as RB_PROD

screenshot

Versions (please complete the following information):

  • Browser chrome
  • Automate Build Number: 20200429153636
@ericcalabretta ericcalabretta added the bug 🐛 Something isn't working label May 9, 2020
@susanev
Copy link
Contributor

susanev commented May 9, 2020

@ericcalabretta thanks for reporting this! our ux design standard is to not change the capitalization of user named objects so this was probably an oversight. @apriofrost can you confirm?

@apriofrost
Copy link

hi @ericcalabretta , thanks for reporting the issue. We're going to update the design spec for the UI component to reflect what you suggested.

UI Implementation Note

Bump the font size for the badge component from 10px to 11px. Instead of automatically capitalize on all the content inside, keep the channel name style as it is.

@SEAjamieD SEAjamieD assigned SEAjamieD and Shadae and unassigned SEAjamieD May 12, 2020
@Shadae Shadae linked a pull request May 12, 2020 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui bug 🐛 Something isn't working ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants