Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix notification delete modal #3659

Closed
2 tasks
susanev opened this issue May 13, 2020 · 0 comments · Fixed by #3694
Closed
2 tasks

fix notification delete modal #3659

susanev opened this issue May 13, 2020 · 0 comments · Fixed by #3694
Assignees
@vinay033
Labels
automate-ui bug 🐛 Something isn't working ui

Comments

@susanev
Copy link
Contributor

susanev commented May 13, 2020

overview

the notification delete modal is using an old design language so we need to update it. it also does not close after you take the delete action, so we should fix that.

design details

before

before

after

after

definition of done

  • modal closes after they take the delete action
  • design language for delete modal is updated
@susanev susanev added bug 🐛 Something isn't working ui automate-ui labels May 13, 2020
@vinay033 vinay033 self-assigned this May 14, 2020
@vinay033 vinay033 mentioned this issue May 15, 2020
Merged
6 tasks
@vinay033 vinay033 linked a pull request May 15, 2020 that will close this issue
fixed for notification delete modal #3694
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinay033 vinay033

Labels
automate-ui bug 🐛 Something isn't working ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed for notification delete modal chef/automate
2 participants
@susanev @vinay033