Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of TabComponent / InfraTabComponent #4866

Closed
SEAjamieD opened this issue Mar 23, 2021 · 3 comments
Closed

Remove duplication of TabComponent / InfraTabComponent #4866

SEAjamieD opened this issue Mar 23, 2021 · 3 comments
Assignees
Labels

Comments

@SEAjamieD
Copy link
Contributor

SEAjamieD commented Mar 23, 2021

InfraTabComponent was created due to difficulty using the already existing TabComponent. Determine if we can fix, otherwise extend TabComponent so that we don't need a duplicate component.

This implementation exists in automate-ui/src/app/modules/infra-proxy/infra-tab-change/infra-tab/infra-tab.component.ts

Screen Shot 2021-04-07 at 2 55 18 PM

Aha! Link: https://chef.aha.io/epics/SH-E-351

@SEAjamieD
Copy link
Contributor Author

@jong-progress - Regarding the tabs outlined in the image above, do you know if we have any plans to use this style of tabs again in the future?

It's so different than our chef-tab-selection used in other pages that I think they probably should just be a one off component set.

@jong-progress
Copy link

@SEAjamieD yeah, this may be considered a new component. This was something new @ManishUX designed . I know he has also updated our tabs, but I think this is its own beast.

@SEAjamieD
Copy link
Contributor Author

ok, thanks @jong-progress - I think this should stay for now then. If we end up using it more we can make it flexible. Thanks!

closing this ticket as it's not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants