Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications for client run failures incorrectly identify failing cookbook when using 'ignore_failure' property. #529

Closed
brywilliamsCF opened this issue Jun 6, 2019 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working community issues submitted by community folks notifications This issue or pull request pertains to notifications in Automate

Comments

@brywilliamsCF
Copy link

Description

If a client run contains a resource that fails but uses the 'ignore_failure' property, notifications sent for any later client run failures will incorrectly refer to the cookbook containing the first ignored resource and not the cookbook containing the resource that actually stopped the client run and triggered the notification. Applies to Slack, ServiceNow, and Webhook notifications.

Automate Version

20190513175357

Replication Case

  1. Create cookbook1 with a resource that will fail but use the 'ignore_failure' property.
  2. Create cookbook2 with a resource that will fail.
  3. Apply both cookbooks to a node.
  4. cookbook1 will fail but the run will continue due to the use of 'ignore_failure'.
  5. cookbook2 will fail, ending the run.
  6. Automate will send a JSON notification. The JSON key 'exception_title' will correctly refer to the failed resource from cookbook2, but the key 'cookbook' will be cookbook1.
@vjeffrey vjeffrey added bug 🐛 Something isn't working notifications This issue or pull request pertains to notifications in Automate labels Jun 7, 2019
@vjeffrey
Copy link

vjeffrey commented Jun 7, 2019

@brywilliamsCF thanks for reporting the issue! I've labeled it as a bug and we will work to get the right people looking at this issue

@lancewf lancewf self-assigned this Jun 18, 2019
@susanev susanev added the community issues submitted by community folks label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working community issues submitted by community folks notifications This issue or pull request pertains to notifications in Automate
Projects
None yet
Development

No branches or pull requests

4 participants