manual bulk node add: modifying tags on one node can delete tags from others

[vjeffrey]

User Story

To reproduce, first get some compliance nodes into Automate node manager with some matching tags like so:

curl -s --insecure -H "api-token: $token_val" https://chef-automate.test/api/v0/nodes/bulk-create -d '
{"nodes": [{
     "name_prefix": "my-ssh-node",
     "manager":"automate",
     "target_config": {
        "backend":"ssh",
        "hosts":["localhost","127.0.0.1"],
        "port": 22
      },
      "tags": [
        { "key":"bleep", "value":"bloop" },
        { "key":"bada", "value":"bing" }
      ]
    },
    {
     "name": "my-other-node",
     "manager":"automate",
      "target_config": {
        "backend":"ssh",
        "hosts":["localhost"],
        "port": 22
      },
      "tags": [
        { "key":"bleep", "value":"bloop" }
      ]
    }
  ]
}'

And then go into Automate node manager, and change the e.g. value for the "bleep" tag on any of the 3 nodes that were added to something else, like "AAA", and the tags on the other nodes disappear afterwards, either all of them, or only the ones that were matching to the tag that was modified – we have observed both.

Definition of Done

Modifying tags on one node has no effect on the tags of another node

Related Resources

https://chefio.atlassian.net/browse/TRI-857?oldIssueView=true

[alexpop]

Looking into this...