This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Basic integration between ChefDK and DCO #1046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
My feelings are that we should ship the DCO tool in chefdk, but it should not be a chef subcommand; since it's not directly involved in the flow of writing and delivering cookbooks. |
|
@thommay That works for me :) Just (ab)using this PR for a moment to check that might rewrites work with dcob. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't actually work until I release the 1.0 of the gem (probably tomorrow, waiting for confirmation from peoples that it meets our legal requirements), but opening now for discussion. I would like to include this gem with ChefDK to help contributors to Chef itself more easily navigate DCO. We could just include it as its own executable and leave things at that, which I would be totally cool with, but this seemed like a nice touch. It exposes the same commands via a
chef dcosubcommand, making it feel a bit more like Chef is giving you tools to do DCO-y things.You can find more info about my
dcocommand over in its readme. What say we all?