This repository has been archived by the owner on Jul 14, 2021. It is now read-only.
Extract Table Printing Logic #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @ui = ui | ||
| @column_widths = [] | ||
|
|
||
| yield self |
|
👍 overall |
danielsdeleo
force-pushed
the
dry-table-print
branch
from
0129534
to
7c4f55c
Compare
| row = "" | ||
| cells.each_with_index do |cell_data, i| | ||
| row << cell_data.to_s.ljust(@column_widths[i]) | ||
| row << " " |
There was a problem hiding this comment.
This may be personal preference, but when printing tables I think a tab (two spaces) between columns makes it more readable. Otherwise the row with the longest values in each column starts to read like a sentence.
|
Great refactor! |
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Disable gem install berkshelf during builds since it's not used anymore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves repeated table print logic into a class. Also moves the report classes for policyfile install and upload to their own part of the file hierarchy (and namespace), and adds tests for them.
/cc @opscode/client-engineers