Add additional Autoscaling and Cloudwatch resources #462
Conversation
rgeddis
changed the title
|
👍 |
|
awesome! can't wait until this gets merged in 👍 |
| statistic 'Average' | ||
| threshold 80 | ||
| alarm_actions [ | ||
| scaling_group.aws_object.scaling_policies['my-scaling-policy'].arn |
There was a problem hiding this comment.
I'm thinking this needs a lazy wrapper around it because the aws_object won't exist during the first compile
|
|
||
| aws_sdk_type AWS::CloudWatch::Alarm, id: :name | ||
|
|
||
| attribute :name, :kind_of => String, :name_attribute => true |
There was a problem hiding this comment.
Would be nice, since this is a new provider, to respect the new "standard" of RFC 054:
https://github.com/chef/chef-rfc/blob/master/rfc054-resource-attribute-improvements.md
| notification_configurations [{ | ||
| topic: driver.build_arn(service: 'sns', resource: 'test_topic'), | ||
| types: [ | ||
| 'autoscaling:EC2_INSTANCE_LAUNCH', |
There was a problem hiding this comment.
Thinking if the "types" should be validated somehow in compilation time.
If not in this PR, at least raise an feature issue, to make that later I guess. What do you think?
|
I'm ok with this pull request. Just raised some nice to have questions, but imo we can merge it @tyler-ball |
|
@joaogbcravo If AWS gives good error messages I don't like to duplicate validation on our side that they will perform. I'll check and see if the error messages are good for your suggestions above! |
…ded support for updating the resource and expanded testing.
#462 from cloudsmith-io/master
|
Merged in 7f57009 - not sure why it didn't close this PR, I didn't do a rebase. Thanks for the work on this one! |
New resources include: